RFR: 8316423: [linux] Secondary Stage does not respect Scene's dimensions when shown [v8]
Lukasz Kostyra
lkostyra at openjdk.org
Fri Oct 27 11:46:49 UTC 2023
On Tue, 24 Oct 2023 23:07:04 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:
>> The bug on the title happens because `gtk_widget_realize()` was called on the constructor. It creates the internal underlying window `GdkWindow` and `XWindow` messing the Gtk expected order. It's probably a Mutter change rather than Gtk. But makes sense to not realize it before expected on the gtk/mutter flow.
>>
>> I moved the code to get the `GdkWindow` to the realize event.
>>
>> Had to change the background function because it's called before realize.
>>
>> The initial **Maximized** and **FullScreen** situations are probably a bug on Mutter [filed here](https://gitlab.gnome.org/GNOME/mutter/-/issues/3092).
>>
>> I could work-around it on this situation, but it would still happen on later focus request.
>
> Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:
>
> - Fix unwanted changes
> - Fix unwanted changes
> - Merge branch 'master' into window_size
> - Fix unwanted changes
> - Fix background
> - Revert "Test"
>
> This reverts commit ac7b4da75b9690c42aecd484bb3990866a004074.
> - Test
> - Experiment on not realizing the window
> - Experiment on not realizing the window
> - Re-enable tests
> - ... and 3 more: https://git.openjdk.org/jfx/compare/27239245...315e1b73
Fix looks good. Tests still fail as expected so they should stay ignored (due to other Linux-related issues) but the issue-attached test app works as intended now and shows proper dimensions.
-------------
Marked as reviewed by lkostyra (Committer).
PR Review: https://git.openjdk.org/jfx/pull/1249#pullrequestreview-1701591550
More information about the openjfx-dev
mailing list