RFR: 8311216: DataURI can lose information in some charset environments [v3]

[Michael Strauß]

On Sat, 28 Oct 2023 19:59:38 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review changes
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/util/DataURI.java line 211:
> 
>> 209:     private static byte[] decodePercentEncoding(String input) {
>> 210:         try (var output = new ByteArrayOutputStream(size(input))) {
>> 211:             decodePercentEncodingToStream(input, output);
> 
> Thanks for making this change, I think it is a good improvement.  
> 
> minor: The `ByteArrayOutputStream` and its not so useful `IOException`s can now be eliminated by having `decodePercentEncodingToStream` accepting a 2nd parameter size, and having it create and return a `byte[]` directly.

I removed `ByteArrayOutputStream`.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1165#discussion_r1375317804