RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu [v2]
vlaaad
duke at openjdk.org
Mon Oct 30 11:27:59 UTC 2023
> This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445).
>
> Context: the warning might be more important than it seems. Our JavaFX-based desktop app has [an issue](https://github.com/defold/defold/issues/7845) — when the user opens 2 instances of the app, one of the instances hangs after a while. While debugging the issue, I found that it's somehow related to the system menu bar — not refreshing it fixes the issue. Further investigations revealed that the app hangs only if we show menus that use F1-F24 shortcuts. This reminded me of the warnings we get about `NSEventModifierFlagFunction specified to -setKeyEquivalentModifierMask` for such shortcuts. I experimented with removing the modifier for these shortcuts, and it helped with our issue!
vlaaad has updated the pull request incrementally with one additional commit since the last revision:
Revert java changes and set NSFunctionKeyMask for non-F1-F24 menu items
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/1252/files
- new: https://git.openjdk.org/jfx/pull/1252/files/39a42f47..115663b0
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=1252&range=01
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=1252&range=00-01
Stats: 12 lines in 2 files changed: 1 ins; 0 del; 11 mod
Patch: https://git.openjdk.org/jfx/pull/1252.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1252/head:pull/1252
PR: https://git.openjdk.org/jfx/pull/1252
More information about the openjfx-dev
mailing list