RFR: JDK-8269921 TextFlow: listeners on bounds can throw NPE while computing text bounds [v5]
Andy Goryachev
angorya at openjdk.org
Mon Oct 30 15:25:49 UTC 2023
On Mon, 30 Oct 2023 15:00:08 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:
>> I mean, are we missing another step?
>
> Yes, we are definitely missing something.
> I looked at it for quite some time, without a better solution as this check.
> If you'd like to investigate further - I would recommend you look into the stack trace of the ticket.
> It's related to updating the bounds of the Node.
I would suggest investigating this a bit further.
The semantics of this method is to return valid Bounds, and it looks like we do not honor this contract. It is possible that we get the original exception because the listener is being called during layout (just guessing) - will this method be called again and return the valid value second time? Or do we need to actually call the layout() to ensure that we do, in fact, have a valid layout every time this method is called?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/564#discussion_r1376404513
More information about the openjfx-dev
mailing list