RFR: JDK-8187314: All Cells: must show backing data always
Andy Goryachev
angorya at openjdk.org
Mon Oct 30 23:17:41 UTC 2023
On Fri, 4 Aug 2023 18:13:34 GMT, Marius Hanl <mhanl at openjdk.org> wrote:
> Before, the `updateItem` method was called with the new value that was committed via `commitEdit()`.
> This is problematic as developers may setup a commit handler via `setOnEditCommit`, which may reject the edit (or change the value otherwise).
> We therefore do call the `updateItem(-1)` which will also call `updateItem` but with the real underlying value.
>
> Changed and added tests for all 4 cells.
🕶 looks good, thanks!
TreeTableView with multiple columns:
https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/bugs/TreeTableView_8187314.java
works as expected.
-------------
Marked as reviewed by angorya (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1197#pullrequestreview-1705214618
PR Comment: https://git.openjdk.org/jfx/pull/1197#issuecomment-1786189248
More information about the openjfx-dev
mailing list