RFR: 8316518 javafx.print.Paper getWidth / getHeight rounds values, causing errors. [v2]
Florian Kirmaier
fkirmaier at openjdk.org
Tue Oct 31 11:46:57 UTC 2023
> The Method javafx.print.getWidth and getHeight returns a double of points.
> But the values are always rounded to full integers. This causes especially problems,
> with mm based Papers.
>
> I asked in the mailing list, with the conclusion (me and John Hendrix) that is best to just fix this behavior by removing the rounding.
Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
JDK-8316518
small change based on codereview
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/1244/files
- new: https://git.openjdk.org/jfx/pull/1244/files/e84c14a7..cc3ba365
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=1244&range=01
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=1244&range=00-01
Stats: 6 lines in 1 file changed: 0 ins; 1 del; 5 mod
Patch: https://git.openjdk.org/jfx/pull/1244.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1244/head:pull/1244
PR: https://git.openjdk.org/jfx/pull/1244
More information about the openjfx-dev
mailing list