RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v8]
Andy Goryachev
angorya at openjdk.org
Tue Oct 31 15:59:47 UTC 2023
On Tue, 31 Oct 2023 15:54:40 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
> if (!cor.equals(ComponentOrientation.UNKNOWN)) {
> boolean rtl = cor.equals(ComponentOrientation.RIGHT_TO_LEFT);
> stage.setNodeOrientation(rtl ? NodeOrientation.RIGHT_TO_LEFT :
> NodeOrientation.LEFT_TO_RIGH**T); } else { stage.setNodeOrientation(NodeOrientation.LEFT_TO_RIGHT);**
> }
I think it should do a simple translation:
LTR -> LTR
RTL -> RTL
UNKNOWN -> INHERIT
> Presuming we want to treat UNKOWN the same as RIGHT_TO_LEFT
no, we want to treat is as INHERIT, i.e. back to initial state. INHERIT shows up as LTR.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1271#issuecomment-1787505596
PR Comment: https://git.openjdk.org/jfx/pull/1271#issuecomment-1787510253
More information about the openjfx-dev
mailing list