RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v8]

Andy Goryachev angorya at openjdk.org
Tue Oct 31 16:29:45 UTC 2023


On Tue, 31 Oct 2023 16:19:24 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> For the Scene, yes, but we aren't talking about that.

I got confused by the variable name "stage".  You are right!  

The last code https://github.com/openjdk/jfx/pull/1271/commits/3b7be5d9888a24a5d1db2a5abcad3c647533544f works as expected.

Perhaps we can clean up the logic a bit, something like


boolean rtl = ComponentOrientation.RIGHT_TO_LEFT.equals(cor);
stage.setNodeOrientation(rtl ? RTL : LTR)

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1271#issuecomment-1787557738


More information about the openjfx-dev mailing list