RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v12]

Sai Pradeep Dandem duke at openjdk.org
Tue Oct 31 21:49:03 UTC 2023


On Mon, 30 Oct 2023 16:17:20 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Sai Pradeep Dandem has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8185831: Changes to doc as per review comments
>
> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 1988:
> 
>> 1986:      *     a pseudo state "myPseudo", then to find all nodes with "myPseudo" state, the lookupAll method can be used as follows:
>> 1987:      *     {@code scene.lookupAll(".myStyle:myPseudo");} or {@code scene.lookupAll(":myPseudo");}. If no pseudo class is specified
>> 1988:      *     by the lookupAll selector, irrespective of the nodes pseudo states the result will contain all nodes matching the selector.
> 
> Please make the same change regarding the last sentence that you did in the `lookup` method (move it before the examples and reword to match `lookup`).

Sorry overlooked that... done now.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1245#discussion_r1378194544


More information about the openjfx-dev mailing list