Withdrawn: 8311216: DataURI can lose information in some charset environments

[duke]

On Sat, 1 Jul 2023 22:24:09 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

> DataURI uses the following implementation to decode the percent-encoded payload of a "data" URI:
> 
> 
> ...
> String data = uri.substring(dataSeparator + 1);
> Charset charset = Charset.defaultCharset();
> ...
> URLDecoder.decode(data.replace("+", "%2B"), charset).getBytes(charset)
> 
> 
> This approach only works if the charset that is passed into `URLDecoder.decode` and `String.getBytes` doesn't lose information when converting between `String` and `byte[]` representations, as might happen in a US-ASCII environment.
> 
> This PR solves the problem by not using `URLDecoder`, but instead simply decoding percent-encoded escape sequences as specified by RFC 3986, page 11.
> 
> **Note to reviewers**: the failing test can only be observed when the JVM uses a default charset that can't represent the payload, which can be enforced by specifying the `-Dfile.encoding=US-ASCII` VM option.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jfx/pull/1165