RFR: 8308608: [testbug] Use Util::waitForIdle instead of Toolkit::firePulse in system tests

[Andy Goryachev]

On Mon, 4 Sep 2023 10:47:02 GMT, Karthik P K <kpk at openjdk.org> wrote:

> Made changes to use Util::waitForIdle instead of Toolkit::firePulse in system tests. The test will wait for default value of 10 pulses to complete in the scene before executing the subsequent statements.

tests/system/src/test/java/test/robot/javafx/scene/ChoiceBoxScrollUpOnCollectionChangeTest.java line 101:

> 99:         });
> 100: 
> 101:         Util.waitForIdle(scene);

is this the right place for waitForIdle?  should it be on L98? since there are multiple key presses involved?

and also, do we still need to .sleep() on L103?

tests/system/src/test/java/test/robot/javafx/scene/ContextMenuNPETest.java line 104:

> 102:             robot.keyType(KeyCode.ENTER);
> 103:         });
> 104:         Util.waitForIdle(scene);

once we have waitForIdle, do we still need to wait() ?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1230#discussion_r1316365449
PR Review Comment: https://git.openjdk.org/jfx/pull/1230#discussion_r1316366508