RFR: 8301302: Platform preferences API [v5]

[Michael Strauß]

On Tue, 5 Sep 2023 19:18:04 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed application preferences implementation
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/application/PlatformImpl.java line 1081:
> 
>> 1079:     public static void updatePreferences(Map<String, Object> preferences) {
>> 1080:         if (isFxApplicationThread()) {
>> 1081:             checkHighContrastThemeChanged(preferences);
> 
> is this needed in this preferences-only PR?

Yes. This PR replaces the special-purpose implementation to retrieve the theme name of the Windows platform with a general-purpse implementation to retrieve all kinds of preferences. We need to retain the theme name handling, otherwise high-contrast support for the Caspian and Modena themes doesn't work.

> modules/javafx.graphics/src/main/java/com/sun/javafx/application/PlatformImpl.java line 1093:
> 
>> 1091: 
>> 1092:     // This method will be removed when StyleThemes are added.
>> 1093:     private static void checkHighContrastThemeChanged(Map<String, Object> preferences) {
> 
> is this needed?

Yes, see above.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1316496781
PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1316496877