RFR: 8301302: Platform preferences API [v9]
Andy Goryachev
angorya at openjdk.org
Wed Sep 6 20:45:08 UTC 2023
On Wed, 6 Sep 2023 20:40:31 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line 472:
>>
>>> 470: * <tbody>
>>> 471: * <tr><th colspan="2" scope="colgroup">Windows</th></tr>
>>> 472: * <tr><td>{@code Windows.SPI.HighContrast}</td><td>{@link Boolean}</td></tr>
>>
>> would it be possible to sort the keys alphabetically?
>
> I don't think that's necessarily a good idea. I've reordered some of them, but others should be grouped. For example: it makes sense to keep the following keys together:
> * `macOS.NSColor.labelColor`
> * `macOS.NSColor.secondaryLabelColor`
> * `macOS.NSColor.tertiaryLabelColor`
> * `macOS.NSColor.quaternaryLabelColor`
>
> Another example:
> * `macOS.NSColor.textBackgroundColor`
> * `macOS.NSColor.selectedTextBackgroundColor`
>
> As it is, most of the keys appear in the same order as they appear in the respective platform's developer documentation.
makes sense, thank you for clarification.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1317813366
More information about the openjfx-dev
mailing list