RFR: 8301302: Platform preferences API [v12]

[Kevin Rushforth]

On Wed, 6 Sep 2023 20:41:25 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> Please read [this document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for an introduction to the Platform Preferences API, and how it interacts with the proposed style theme and stage appearance features.
>
> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
> 
>   changes per review

modules/javafx.graphics/src/main/java/javafx/application/Platform.java line 582:

> 580:          *
> 581:          * @return the platform appearance
> 582:          */

Please remove this javadoc block. Properties should only have docs on the xxxProperty method (or, for concrete classes, the private xxxx field), not on the setters and getters. This will allow javadoc to copy the information from the property, and generate cross-links.

modules/javafx.graphics/src/main/java/javafx/application/Platform.java line 599:

> 597:          *
> 598:          * @return the background color
> 599:          */

Remove this javadoc block.

modules/javafx.graphics/src/main/java/javafx/application/Platform.java line 616:

> 614:          *
> 615:          * @return the foreground color
> 616:          */

and this one

modules/javafx.graphics/src/main/java/javafx/application/Platform.java line 633:

> 631:          *
> 632:          * @return the accent color
> 633:          */

and this one

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1317834094
PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1317834392
PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1317834594
PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1317834690