RFR: 8313651: Add 'final' keyword to public property methods in controls [v6]

[Andy Goryachev]

On Fri, 8 Sep 2023 13:02:31 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'origin/master' into 8313651.final
>>  - review comments
>>  - review comments
>>  - review comments
>>  - review comments
>>  - Merge remote-tracking branch 'origin/master' into 8313651.final
>>  - review comments
>>  - whitespace
>>  - added final keyword
>>  - test
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java line 177:
> 
>> 175: 
>> 176:     private void check(Class cls) {
>> 177:         Method[] methods = cls.getMethods();
> 
> This will only return public methods. Since you modified `checkModifiers` to check protected methods, you will need to use `getDeclaredMethods` instead. This will return protected (and package scope) methods as well as public methods. It won't return any method in a superclass, but since the set of classes you are checking includes intermediate classes (such as `ButtonBase` and `Labeled`), you will still get the coverage (and without redundantly checking the same method in those classes multiple times).

Right, what was I thinking??
And we also have Region.setWidth() which is protected and not final by design.  Reverting the last change.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1213#discussion_r1319975064