RFR: 8311527: Region.snapInnerSpace*() [v2]

[Andy Goryachev]

On Thu, 7 Sep 2023 16:41:23 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Introduces Region.snapInnerSpaceX/Y() methods for dealing with inner space (using Math.floor), see for instance [JDK-8299753](https://bugs.openjdk.org/browse/JDK-8299753), using existing methods Region.snapPortionX/Y().
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
> 
>  - review comments
>  - Merge remote-tracking branch 'origin/master' into ag.8311527.snap.inner
>  - tests
>  - Merge remote-tracking branch 'origin/master' into ag.8311527.snap.inner
>  - javadoc
>  - snap portion
>  - cleanup
>  - 8311527: snap inner space

I don't understand the comment about "theoretical use case" - the case of CPane is practical enough for me.  The fact that javafx does not provide a good table layout Pane (and a GridPane is as clunky as its ancestor GridBagLayout) and we have not yet encountered the need for it is not, in my opinion, a good argument.

Can this functionality be written by an app developer?  Yes, so I am not that concerned.

I am even ok to withdraw this PR, but I still think there is a value in providing this API as a part of the core.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1190#issuecomment-1711825547