RFR: 8313651: Add 'final' keyword to public property methods in controls [v4]

Kevin Rushforth kcr at openjdk.org
Fri Sep 8 17:22:47 UTC 2023


On Tue, 22 Aug 2023 09:46:28 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> Looks good. Gave a couple of minor optional suggestions.
> 
> As to the topic of class finding, I think it's fine to use a manual list, at least for now. The complexity of automatically detecting the classes might not be worth the hassle. Leaving it up to you.

@nlisker @hjohn Can you re-review?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1213#issuecomment-1711995781


More information about the openjfx-dev mailing list