RFR: 8313651: Add 'final' keyword to public property methods in controls [v7]
Andy Goryachev
angorya at openjdk.org
Fri Sep 8 18:37:46 UTC 2023
On Fri, 8 Sep 2023 18:18:30 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> only public
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java line 99:
>
>> 97: public class ControlPropertiesTest {
>> 98:
>> 99: private static final boolean FAIL_FAST = true;
>
> Please add a short comment on what this is for. Like "If true, an exception will be thrown on encountering the first violating class, otherwise a list of all violating cases will be printed".
good point, thanks!
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1213#discussion_r1320207983
More information about the openjfx-dev
mailing list