[jfx-tests] RFR: 8315842: 3D tests fail because of edge pixel differences

[Jayathirth D V]

On Fri, 8 Sep 2023 12:15:35 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

> A static constant can be added to `test.scenegraph.fx3d.utils.FX3DAbstractApp` public static final float COLOR_TOLERANCE = 0.05f;
> 
> This can easily be accessed in test classes without FX3DAbstractApp instance as - `Root.ROOT.getEnvironment().setProperty(ImageComparator.class, new GlassPixelImageComparator(new PixelEqualityRasterComparator(FX3DAbstractApp.COLOR_TOLERANCE)));`
> 
> This will allow us to tweak the tolerance value at a single place in future and not in all the 26 files.
> 
> This change is pretty safe as and just a sanity check would be needed. If a test does not use FX3DAbstractApp, then you can keep the hard-coded constant.

Thanks @aghaisas for your inputs.
I have updated the code to use common variable.

-------------

PR Comment: https://git.openjdk.org/jfx-tests/pull/5#issuecomment-1713179402