RFR: 8305709: [testbug] Tree/TableViewResizeColumnToFitContentTest fails with fractional screen scale

Karthik P K kpk at openjdk.org
Mon Sep 11 06:25:44 UTC 2023


On Thu, 7 Sep 2023 18:26:50 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> Snapping introduces differences between computed values and snapped values, so we need to use non-zero tolerance when checking for equality.  The maximum tolerance is (1 / scale) - one display pixel scaled back to the local coordinates.
> 
> The tests have been modified to use the scale-specific tolerance.
> 
> Tested with macOS at scale 1.0 and win11 at scales (100%, 125%, 150%, 175%).

LGTM

-------------

Marked as reviewed by kpk (Committer).

PR Review: https://git.openjdk.org/jfx/pull/1234#pullrequestreview-1619204773


More information about the openjfx-dev mailing list