[jfx-tests] Integrated: 8315842: 3D tests fail because of edge pixel differences
Jayathirth D V
jdv at openjdk.org
Mon Sep 11 06:40:44 UTC 2023
On Thu, 7 Sep 2023 10:17:28 GMT, Jayathirth D V <jdv at openjdk.org> wrote:
> Out of 62 3D tests, 26 tests fail because of minute color differences in edge pixels.
> These tests are used to verify 3D rendering with different parameters like translation, rotation.
>
> So adding little color tolerance will not change the test behavior and allows us to use these tests to automatically verify any regression introduced in 3D rendering.
>
> Added 5% color tolerance and with this change 23 of these tests pass.
>
> Some sub-tests under below 3 tests continue to fail because of other reasons:
> [test/scenegraph/fx3d/camera/fixedeye/PerspectiveCameraFixedEyeIsolateTest.java](file:///Users/jdv/dev/workspace/jfx/jfx-tests/functional/3DTests/build/test.workdir/test/scenegraph/fx3d/camera/fixedeye/PerspectiveCameraFixedEyeIsolateTest.jtr)
> [test/scenegraph/fx3d/camera/parallel/ParallelCameraIsolateTest.java](file:///Users/jdv/dev/workspace/jfx/jfx-tests/functional/3DTests/build/test.workdir/test/scenegraph/fx3d/camera/parallel/ParallelCameraIsolateTest.jtr)
> [test/scenegraph/fx3d/camera/perspective/PerspectiveCameraIsolateTest.java](file:///Users/jdv/dev/workspace/jfx/jfx-tests/functional/3DTests/build/test.workdir/test/scenegraph/fx3d/camera/perspective/PerspectiveCameraIsolateTest.jtr)
>
> Also i see that some of the camera tests just draw white images, this also needs to be verified.
> With this change 41 out of 62 3D tests will run properly.
This pull request has now been integrated.
Changeset: 0d35c195
Author: Jayathirth D V <jdv at openjdk.org>
Committer: Ajit Ghaisas <aghaisas at openjdk.org>
URL: https://git.openjdk.org/jfx-tests/commit/0d35c195e060d6c3e77424853417d2a5fd47620c
Stats: 171 lines in 27 files changed: 171 ins; 0 del; 0 mod
8315842: 3D tests fail because of edge pixel differences
Reviewed-by: aghaisas
-------------
PR: https://git.openjdk.org/jfx-tests/pull/5
More information about the openjfx-dev
mailing list