RFR: 8310666: gradle validateSourceSets task not run when TEST_ONLY=true

Mon Sep 11 11:38:47 UTC 2023

On Mon, 11 Sep 2023 09:23:06 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

> The validateSourceSets task are created only for the test tasks. [check source](https://github.com/openjdk/jfx/blob/eb7de72dafecbedc83c2215b6aed7432d4ec80f9/build.gradle#L1848)
> So, validateSourceSets task must be executed when running test tasks even when TEST_ONLY=true.
> This had caused a regression [JDK-8310654](https://bugs.openjdk.org/browse/JDK-8310654), where we missed a failing scenario as validateSourceSets did not run with -PTEST_ONLY=true

Looks good. One suggestion, possibly for a follow-up enhancement, would be to move all of the logic to `isTestTask`. As part of this, you could consider documenting and treating `validate` and/or `verify` as prefixes that are treated as test tasks.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1237#pullrequestreview-1619771102