RFR: 8315958: Missing range checks in GlassPasteboard

Johan Vos jvos at openjdk.org
Wed Sep 13 06:11:45 UTC 2023


On Mon, 11 Sep 2023 15:55:44 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> This PR adds missing range checks in the native `_getItemAsRawImage` and `ByteArrayFromPixels` methods in `GlassPasteboard.m` (for both mac and ios).
> 
> Note that these checks are _very_ unlikely to ever detect an error in practice, since they would require a huge image to be copied to the macOS system clipboard (larger than can be created using a Java program). If this were to be detected, no exception would (or should be) thrown, given that the method that triggers this is the reading of the clipboard (so there is nothing that the application is doing wrong for which an exception would make sense).

ios changes are ok

-------------

Marked as reviewed by jvos (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1238#pullrequestreview-1623757178


More information about the openjfx-dev mailing list