RFR: 8298500: Create test to initially show stage with various attributes (iconified, maximized, full screen)

Andy Goryachev angorya at openjdk.org
Wed Sep 13 15:41:46 UTC 2023


On Wed, 13 Sep 2023 15:32:15 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:

>> tests/system/src/test/java/test/robot/javafx/stage/AttributesTest.java line 48:
>> 
>>> 46: import static test.util.Util.TIMEOUT;
>>> 47: 
>>> 48: public class AttributesTest extends VisualTestBase {
>> 
>> a brief javadoc explaining what this test does would be nice.
>> also, perhaps the class name could be more descriptive, i.e. StageAttributesTest or something like that.
>
> I'll add the javadoc.
> 
> I skipped the `Stage` prefix since this test is in a directory of `Stage`-related tests. Should I still add it despite that?

The more specific the class name, the better, I think (and also, specific names reduce collisions)

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1240#discussion_r1324715928


More information about the openjfx-dev mailing list