RFR: JDK-8199216: Quadratic layout time with nested nodes and pseudo-class in style sheet [v8]

Kevin Rushforth kcr at openjdk.org
Thu Sep 14 22:42:19 UTC 2023


On Wed, 16 Aug 2023 14:02:01 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> Then the map is just an optimization? If the set points to itself then a `Set` as a cache should be enough.
>
> No, a `Set` wouldn't work here, for this reason:
> 
>       if (CACHE.contains(mutableSet)) {
>              return ... // how do I get the immutable set from CACHE when it is a Set?
>       }

I just finished my review of the code, and this (why a `Map` rather than a `Set`) was the only question I had. I looked at the resolved threads, and I see that it has been asked and answered. Good.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1076#discussion_r1326581679


More information about the openjfx-dev mailing list