RFR: 8298500: Create test to initially show stage with various attributes (iconified, maximized, full screen) [v2]

Kevin Rushforth kcr at openjdk.org
Fri Sep 15 15:24:46 UTC 2023


On Fri, 15 Sep 2023 14:48:03 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:

> * On macOS `testMaximizedStageBeforeShow` and `testIconifiedStageBeforeShow` fail because stages are not shown already iconified/maximized. Rest of the tests work fine - I assume a bug in functionality that needs to be fixed.

[JDK-8305675](https://bugs.openjdk.org/browse/JDK-8305675) is already tracking the failure of an initially iconified window. You can use that bug ID when adding the "assumeFalse" to exclude the test on macOS.

I don't see a bug tracking the failure of a maximized window. [JDK-8253997](https://bugs.openjdk.org/browse/JDK-8253997) describes a problem where the window is shown normal size and then animated to maximized. Perhaps the behavior has changed on recent macOS systems. Can you check by running that test program attached to that bug? If it behaves the same way as your new test, then we can repurpose that bug; otherwise, please file a new bug.

> * On Linux all tests fail, on my VM (Fedora 38 with X11) the stages are created without taking into account WIDTH/HEIGHT parameters provided to the Scene. They are created smaller than expected (I guess 100x100), so `getColor()` calls return background colors (terminal background/letters in my case). This could be cured in-test of course, but it also seems like a bug that should be ironed out (we do expect stages to be larger after all). After forcing proper width/height, testMaximizedStageBeforeShow/testFullScreenStageBeforeShow both fail - I noticed top stage is created maximized/fullscreen and immediately brought back to default dimensions, so I think it's another to-be-fixed bug.

Yes, it does seem like there are two or three product bugs on Linux. Can you file new bugs, and then use those bug IDs to exclude the failing tests on Linux? I'll test this on Ubuntu and see if that behaves differently than Fedora.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1240#issuecomment-1721456629


More information about the openjfx-dev mailing list