RFR: 8298500: Create test to initially show stage with various attributes (iconified, maximized, full screen) [v4]
Kevin Rushforth
kcr at openjdk.org
Mon Sep 18 14:29:53 UTC 2023
On Wed, 13 Sep 2023 15:05:49 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Lukasz Kostyra has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix skip comment on testMaximizedStageBeforeShow
>>
>> Comment pointed at wrong JDK issue (aka. Copy-Paste's Error)
>
> tests/system/src/test/java/test/robot/javafx/stage/AttributesTest.java line 134:
>
>> 132:
>> 133: // wait a bit to let window system animate the change
>> 134: sleep(1000);
>
> could we use Util.waitForIdle() here instead of the fixed timeout?
Actually, no. This isn't the intended use case for `waitForIdle`. That method should only be used when waiting for scene graph changes to propagate, not for the platform to finish showing or animating a window.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1240#discussion_r1328815606
More information about the openjfx-dev
mailing list