RFR: JDK-8316590: Rendering artifact after JDK-8311983

Thu Sep 21 14:41:48 UTC 2023

On Thu, 21 Sep 2023 14:27:59 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

> Fixes the regression by basically reverting one change introduced in https://bugs.openjdk.org/browse/JDK-8311983.
> The problem is that it is actually required to get the size from a cell with the index -1, which technically does not exist (the accumCell is used then).
> 
> Furthermore, unlike the name suggests, the call to `addLeadingCells()` is always needed, even if there are none.
> This is because the method does much more than what you would think first. 
> 
> In future, it would probably be good to revisit this code. Also performance wise, since this looks like something that can be optimized. But that is another story, not related to this fix.

Reviewers: @andy-goryachev-oracle @karthikpandelu

@johanvos You also might want to take a look.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1246#issuecomment-1729717561
PR Comment: https://git.openjdk.org/jfx/pull/1246#issuecomment-1729721082