RFR: 8299753: Tree/TableView: Column Resizing With Fractional Scale [v6]

Andy Goryachev angorya at openjdk.org
Thu Sep 21 14:50:39 UTC 2023


> Modified the resize algorithm to work well with fractional scale, thanks for deeper understanding of the problem thanks to  @hjohn and @mstr2 .
> 
> It is important to note that even though the constraints are given by the user in unsnapped coordinates, they are converted to snapped values, since the snapped values correspond to the actual pixels on the display.  This means the tests that validate honoring constraints should, in all the cases where (scale != 1.0), assume possibly error not exceeding (1.0 / scale) (I think).

Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 25 additional commits since the last revision:

 - tolerance
 - Merge remote-tracking branch 'origin/master' into 8299753.resize
 - undo merge
 - no new api
 - Merge remote-tracking branch 'origin/master' into 8299753.resize
 - cleanup
 - using snap inner space api
 - Merge remote-tracking branch 'origin/master' into 8299753.resize
 - Merge branch 'ag.8311527.snap.inner' into 8299753.resize
 - tests
 - ... and 15 more: https://git.openjdk.org/jfx/compare/141f8575...abd9af92

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1156/files
  - new: https://git.openjdk.org/jfx/pull/1156/files/df87de91..abd9af92

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1156&range=05
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1156&range=04-05

  Stats: 1296 lines in 35 files changed: 1019 ins; 116 del; 161 mod
  Patch: https://git.openjdk.org/jfx/pull/1156.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1156/head:pull/1156

PR: https://git.openjdk.org/jfx/pull/1156


More information about the openjfx-dev mailing list