RFR: 8307176: Monkey Tester Application Part 2 [v3]

Andy Goryachev angorya at openjdk.org
Thu Sep 21 16:39:38 UTC 2023


On Thu, 21 Sep 2023 16:07:16 GMT, Martin Fox <duke at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   system info
>
> tests/manual/monkey/src/com/oracle/tools/fx/monkey/tools/KeyboardEventViewer.java line 38:
> 
>> 36:  * Keyboard Event Viewer
>> 37:  */
>> 38: public class KeyboardEventViewer extends BorderPane {
> 
> Yes! Thank you for adding a keyboard event viewer. It is long overdue.
> 
> On Mac and Linux dead keys are handled using InputMethodEvents so I find it essential to catch them and dump out some minimal information. Here's the code I use (`addToLog` simply appends the text to a TextArea with a newline at the end):
> 
> 
>     private void inputMethodTextChangedEvent(InputMethodEvent e) {
>         if (!e.getCommitted().isEmpty()) {
>             addToLog("  Commit: " + e.getCommitted());
>         }
>         if (!e.getComposed().isEmpty()) {
>             String composedText = "";
>             for (InputMethodTextRun run : e.getComposed()) {
>                 composedText += run.getText();
>             }
>             addToLog("Composed: " + composedText);
>         }
>     }

Thank you so much - this is a very good suggestion.  Added.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1241#discussion_r1333335914


More information about the openjfx-dev mailing list