RFR: 8307176: Monkey Tester Application Part 2 [v4]

[Andy Goryachev]

On Thu, 21 Sep 2023 16:39:35 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Adding changes to the MonkeyTester application accumulated since the last test sprint, from a separate repository
>> https://github.com/andy-goryachev-oracle/MonkeyTest
>> 
>> User preferences location:
>> The applications stores its user preferences (window location, etc.) in ~/.MonkeyTester directory.
>> - To use a different directory, redefine the "user.home" system property, -Duser.home=<...>.
>> - To disable saving, specify -Ddisable.settings=true vm agrument.
>> 
>> - ✔ replace setId() with some other way of setting component name
>> - ✔ change property for ui.settings dir
>> - ✔ add pie chart
>> - ✔ ComboBox: The current two buttons don't seem all that useful. I'm not even sure what, exactly, they do. What would be useful is a way to select the number of items in the list (like there is with ChoiceBox)
>> - ✔ ListView: Changing the selection model or checking / unchecking the "null focus model" option clears the list, which is unexpected. Given that there is a separate "clear list" button, it doesn't seem needed either.
>> - ✔ TextField: The default alignment of BASELINE_RIGHT is unexpected (unless there is a good reason, defaults for properties should match the API default to avoid surprises).
>> - ✔ Menu item: Window --> Open Modal Window "Platform.exit()" should not be the default choice (if you press <ENTER> the app will exit)
>> - ✔ TableView: The column sorting feature would be more useful if it were possible to have different data for each row
>> - ✔ Add Skin -> (null skin, set new skin) menus to all related controls to enable leak tests
>> - ✔ TableView: cell factory, cell value factory 
>> - ✔ TreeTableView: cell factory
>> - ✔ TreeView: cell factory
>> - ✔ add massive CJK text for JDK-8090110 / JDK-8089418
>> - ✔ clipboard monitor tool
>> - ✔ add to the status bar: JVM version, JFX version, current directory, screen scale
>> - ✔ WebView page
>> - ✔ Tools -> Keyboard Events Viewer
>> - ✔ System Info tool that reports all the details about the environment such as reported OS version, number of displays, env, system properties
>> 
>> To be continued... JDK-8316372
>
> Andy Goryachev has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - whitespace
>  - input method event

Thank you all for reviewing!
I just wanted to say that the tools is still work in progress, but I think there is some value in releasing it in its current state.

Responding to Karthik's questions:
1. ComboBox page was quickly done for testing one particular bug.  I am planning to change it later with a more complete set of configuration options similar to other pages (btw, what is the scenario where the window becomes unresponsive?  is that another issue?  which platform are you running on?)
2. TableView: yes, it's intentional.
3. Platform.exit() button works but you must press SPACE not ENTER (unexpected, but that's how buttons seem to work in FX)

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1241#issuecomment-1731581149