RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v8]

Andy Goryachev angorya at openjdk.org
Wed Sep 27 15:23:33 UTC 2023


On Wed, 27 Sep 2023 15:15:15 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

>> The return type is Point2D, not int.
>> 
>> But I'm glad you commented on it. I hadn't looked at this PR at all. Adding a method to a public interface is an API change, so at a minimum needs a CSR. More problematic is that since this isn't a default method, it is an incompatible change -- at least if any class outside of the JavaFX runtime were to implement it.
>
> I copied it from `getTextLocation`, but you're right.

the null is in the @param block

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1080#discussion_r1338780056


More information about the openjfx-dev mailing list