RFR: JDK-8317308 JavaFX Developer build broken on Windows - NativeLibrary file contains invalid character ':'

[Kevin Rushforth]

On Fri, 29 Sep 2023 10:40:52 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:

> The format of the timestamp has changed to ISO 8601. This contains the “:” Character.
> A copy of the dll is saved at <home>/.openjfx/cache/" + jfxVersion + "/" + arch .
> On Windows, the character ‘:’ is invalid in files, causing internal errors.
> 
> This only happens on developer/non-hudson builds, because on hudson-builds, the timestamp is omitted.
> 
> I just replaced the disallowed character when creating the native library.

Yeah, I didn't have time to look at it carefully. I agree that it is better to fix this bug at the source, so a follow-up bug would be helpful.

In particular:

> The code shouldn't be writing one java.runtime.version to the properties file while using a different string at runtime.

Yes, this sort of inconsistency is just asking for trouble.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1251#issuecomment-1741238444
PR Comment: https://git.openjdk.org/jfx/pull/1251#issuecomment-1741240380