RFR: JDK-8326619: Stage.sizeToScene() on maximized/fullscreen Stage breaks the Window [v3]
Lukasz Kostyra
lkostyra at openjdk.org
Tue Apr 2 14:23:09 UTC 2024
On Sat, 9 Mar 2024 18:41:10 GMT, Marius Hanl <mhanl at openjdk.org> wrote:
>> This PR fixes the problem that maximizing/fullscreen a `Stage` or `Dialog` is broken when `sizeToScene()` was called before or after.
>>
>> The approach here is to ignore the `sizeToScene()` request when the `Stage` is maximized or set to fullscreen.
>> Otherwise the Window Manager of the OS will be confused and you will get weird flickering or wrong Window buttons (e.g. on Windows, the 'Maximize' button still shows the 'Restore' Icon, while we already resized the `Stage` to not be maximized).
>
> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
>
> improve tests
LGTM, tests also seem to be fine on my end (checked on Windows and Ubuntu 22.04 LTS)
-------------
Marked as reviewed by lkostyra (Committer).
PR Review: https://git.openjdk.org/jfx/pull/1382#pullrequestreview-1973986480
More information about the openjfx-dev
mailing list