RFR: 8319555: [TestBug] Utility for creating instruction window for manual tests [v4]

Andy Goryachev angorya at openjdk.org
Mon Apr 8 22:56:08 UTC 2024


On Mon, 8 Apr 2024 22:23:07 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - works
>>  - .
>
> tests/manual/util/README.md line 19:
> 
>> 17:                  multi-line instructions here.
>> 18:                  """
>> 19:              ).
> 
> Add `size(1200, 800).` to example. I think adjusting size will be common enough and no need to look at `ManualTestWindow` to figure it out.

good point!

> tests/manual/util/README.md line 30:
> 
>> 28: ```
>> 29: 
>> 30: Resulting application window:
> 
> Resulting application window does not look like it is from example above. Not sure if it is important.

Not really important.

Apart from being resized to decrease the size of the PNG image, it looks exactly the same.  Are you running it on a different platform?  How does it look, anything appears missing (can you post a screenshot)?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1413#discussion_r1556506834
PR Review Comment: https://git.openjdk.org/jfx/pull/1413#discussion_r1556507844


More information about the openjfx-dev mailing list