RFR: 8242553: IntegerSpinner and DoubleSpinner do not wrap around values correctly in some cases [v2]

drmarmac duke at openjdk.org
Wed Apr 10 11:47:28 UTC 2024


> This PR should fix the issue and cover all relevant cases with new tests.
> 
> Note: This involves a small behavior change, as can be seen in dblSpinner_testWrapAround_decrement_twoSteps() in SpinnerTest.java:749. With this change the wraparound behavior is similar to that of the IntegerSpinner.

drmarmac has updated the pull request incrementally with one additional commit since the last revision:

  Use direction-dependent modulo arithmetic in DoubleSpinnerValueFactory wrap-around logic

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1431/files
  - new: https://git.openjdk.org/jfx/pull/1431/files/103ac473..6b38b9ce

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1431&range=01
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1431&range=00-01

  Stats: 50 lines in 3 files changed: 9 ins; 10 del; 31 mod
  Patch: https://git.openjdk.org/jfx/pull/1431.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1431/head:pull/1431

PR: https://git.openjdk.org/jfx/pull/1431


More information about the openjfx-dev mailing list