RFR: 8092102: Labeled: truncated property [v8]

Andy Goryachev angorya at openjdk.org
Wed Apr 10 21:30:52 UTC 2024


On Wed, 10 Apr 2024 09:03:33 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add exports
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/LabeledHelper.java line 38:
> 
>> 36:         /**
>> 37:          * Returns true when the Labeled must compute the actual content width in computePrefWidth().
>> 38:          * @return whether computePrefWidth() must compute the actual content width
> 
> Do you think re-wording the sentence to explain when this function returns true/false would be better here?

is the new version clearer?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1389#discussion_r1560075257


More information about the openjfx-dev mailing list