RFR: 8319555: [TestBug] Utility for creating instruction window for manual tests [v6]

[Alexander Matveev]

On Wed, 10 Apr 2024 23:16:02 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> ## ManualTestWindow
>> 
>> This facility provides the base class for manual tests which displays the test instructions,
>> the UI under test, and the Pass/Fail buttons.
>> 
>> Example:
>> 
>> 
>> public class ManualTestExample extends ManualTestWindow {
>>     public ManualTestExample() {
>>         super(
>>             "Manual Test Example",
>>             """
>>             Instructions:
>>             1. you will see a button named "Test"
>>             2. press the button
>>             3. verify that the button can be pressed""",
>>             400, 250
>>         );
>>     }
>> 
>>     public static void main(String[] args) throws Exception {
>>         launch(args);
>>     }
>> 
>>     @Override
>>     protected Node createContent() {
>>         return new Button("Test");
>>     }
>> }
>> 
>> 
>> Resulting application window:
>> 
>> ![ManualTestWindow](https://github.com/openjdk/jfx/assets/107069028/fa29ce47-1ca3-458e-91e9-472da43cd724)
>> 
>> Readme:
>> 
>> https://github.com/andy-goryachev-oracle/jfx/blob/8319555.manual/tests/manual/util/README.md
>> 
>> @prrace 's test EmojiTest has been converted to use the new test window as a demonstration (also fixed the Eclipse project so it works now).
>> 
>> Q: What other features can be added to the test window?
>> 
>> Edit: the sources are left in their original place at the root of the project.
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed example

Only minor comment about unused code. Otherwise looks fine to me.

tests/manual/util/src/com/oracle/util/testing/ManualTestWindow.java line 130:

> 128:         });
> 129:         screenshotButton.setDisable(true);
> 130:         */

I will suggest to delete unused code.

tests/manual/util/src/com/oracle/util/testing/ManualTestWindow.java line 148:

> 146:         HBox buttons = new HBox(
> 147:             10,
> 148:             //screenshotButton,

Same here.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1413#pullrequestreview-1992844835
PR Review Comment: https://git.openjdk.org/jfx/pull/1413#discussion_r1560162005
PR Review Comment: https://git.openjdk.org/jfx/pull/1413#discussion_r1560162155