RFR: 8328577: Toolbar's overflow button overlaps the items [v4]
eduardsdv
duke at openjdk.org
Fri Apr 12 15:21:14 UTC 2024
> This change fixes the calculation of which nodes go to the toolbar and which go to the overflow menu.
> It is now determined before the nodes are removed from the scene graph.
> This is important because the values returned by ``Node.prefWidth(..)``/``Node.prefHeight(..)`` may depend on whether the node is added to the scene graph.
>
> Furthermore I corrected the ``hasOveflow`` value passed to the ``organizeOverflow(double, boolean)`` in ``correctOverflow(double)``.
eduardsdv has updated the pull request incrementally with one additional commit since the last revision:
JDK-8328577: Collect overflowed items in a shadow (overflowBox) pane
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/1434/files
- new: https://git.openjdk.org/jfx/pull/1434/files/09dcc48d..6478f38b
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=1434&range=03
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=1434&range=02-03
Stats: 143 lines in 1 file changed: 81 ins; 54 del; 8 mod
Patch: https://git.openjdk.org/jfx/pull/1434.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1434/head:pull/1434
PR: https://git.openjdk.org/jfx/pull/1434
More information about the openjfx-dev
mailing list