RFR: 8328577: Toolbar's overflow button overlaps the items [v5]
eduardsdv
duke at openjdk.org
Mon Apr 15 12:38:15 UTC 2024
> This change fixes the calculation of which nodes go to the toolbar and which go to the overflow menu.
> It is now determined before the nodes are removed from the scene graph.
> This is important because the values returned by ``Node.prefWidth(..)``/``Node.prefHeight(..)`` may depend on whether the node is added to the scene graph.
>
> Furthermore I corrected the ``hasOveflow`` value passed to the ``organizeOverflow(double, boolean)`` in ``correctOverflow(double)``.
eduardsdv has updated the pull request incrementally with two additional commits since the last revision:
- JDK-8328577: Update comment
- JDK-8328577: Bind style related properties
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/1434/files
- new: https://git.openjdk.org/jfx/pull/1434/files/6478f38b..e63b0b9b
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=1434&range=04
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=1434&range=03-04
Stats: 15 lines in 1 file changed: 12 ins; 0 del; 3 mod
Patch: https://git.openjdk.org/jfx/pull/1434.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1434/head:pull/1434
PR: https://git.openjdk.org/jfx/pull/1434
More information about the openjfx-dev
mailing list