RFR: 8328577: Toolbar's overflow button overlaps the items [v4]
eduardsdv
duke at openjdk.org
Mon Apr 15 14:14:48 UTC 2024
On Mon, 15 Apr 2024 12:28:55 GMT, eduardsdv <duke at openjdk.org> wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/ToolBarSkin.java line 783:
>>
>>> 781: CustomMenuItem customMenuItem = new CustomMenuItem(node);
>>> 782:
>>> 783: // RT-36455:
>>
>> since we moved this code, could we change this line to
>> ` // RT-36455 (JDK-8096292):`
>>
>> and also make sure that this change introduced no regression w.r.t. JDK-8096292 ?
>> (My limited testing indicates that it still works as expected, but please double check)
>
> I tested it with the Modena application. The bug is not reproducible.
I changed the comment. See [e63b0b9](https://github.com/openjdk/jfx/pull/1434/commits/e63b0b9b313131460fbe154ce8af164a3a97672f)
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1434#discussion_r1565868897
More information about the openjfx-dev
mailing list