RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v3]

[Oliver Kopp]

On Thu, 18 Apr 2024 15:10:47 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Oliver Kopp has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix handling of requestedSteps < 0
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/win/WinTextRangeProvider.java line 365:
> 
>> 363:         if (text == null) return null;
>> 364:         validateRange(text);
>> 365:         int endOffset = maxLength >= 0 ? Math.min(end, Math.max(start + maxLength, maxLength)) : end;
> 
> there is a similar code on LL 101,102,381,485
> would we need to apply the same logic there?
> possibly in some kind of a utility method?

Done! Hopefully, not too overengeered - https://github.com/openjdk/jfx/pull/1442/files#diff-cf00c7b3f2ccd166df5df3aabcd0940072739356910a2c2107a9442aec6010dfR105

(The JDK code seems to be very compact)

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1442#discussion_r1571325231