RFR: 8242553: IntegerSpinner and DoubleSpinner do not wrap around values correctly in some cases [v2]

Andy Goryachev angorya at openjdk.org
Thu Apr 18 23:20:03 UTC 2024


On Wed, 10 Apr 2024 11:47:28 GMT, drmarmac <duke at openjdk.org> wrote:

>> This PR should fix the issue and cover all relevant cases with new tests.
>> 
>> Note: This involves a small behavior change, as can be seen in dblSpinner_testWrapAround_decrement_twoSteps() in SpinnerTest.java:749. With this change the wraparound behavior is similar to that of the IntegerSpinner.
>
> drmarmac has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use direction-dependent modulo arithmetic in DoubleSpinnerValueFactory wrap-around logic

I like the idea of updating the spec (for SpinnerValueFactory.[Integer|Double}SpinnerFactory classes).

Do we really need the CSR for clarifying the behavior?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1431#issuecomment-2065471671


More information about the openjfx-dev mailing list