RFR: 8328577: Toolbar's overflow button overlaps the items [v6]

[Karthik P K]

On Mon, 15 Apr 2024 15:41:19 GMT, eduardsdv <duke at openjdk.org> wrote:

>> This change fixes the calculation of which nodes go to the toolbar and which go to the overflow menu.
>> It is now determined before the nodes are removed from the scene graph.
>> This is important because the values returned by ``Node.prefWidth(..)``/``Node.prefHeight(..)`` may depend on whether the node is added to the scene graph.
>> 
>> Furthermore I corrected the ``hasOveflow`` value passed to the ``organizeOverflow(double, boolean)`` in ``correctOverflow(double)``.
>
> eduardsdv has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8328577: Refactor and fix binding of style related properties

Here is the video of issue #2. Strangely I couldn't reproduce the issue when I tried to record it using Mac's inbuilt tool. But using zoom, I could reproduce the issue alternatively.

https://github.com/openjdk/jfx/assets/26969459/60bd48a9-4239-4a16-9c92-8894363b159d

This is the video of issue #3. In this case I was able to reproduce issue #2 as well.

https://github.com/openjdk/jfx/assets/26969459/3ad8b4f2-0b97-4d8e-b80b-64883a9e83e2

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1434#issuecomment-2066498197