RFR: 8328577: Toolbar's overflow button overlaps the items [v6]

[Karthik P K]

On Fri, 19 Apr 2024 16:14:27 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> So, none of them can be reproduced on windows, only on mac.
>> 
>> The #2 can be reproduced in the version before PR and after PR.
>> 
>> The #3 is reproducible only with PR changes and in my opinion an other bug in JavaFX, which is made to appear by this PR.
>> 
>> It can be quick-fixed by adding a ``Platform.runLater(..)`` into WINDO_HIDDEN event handler:
>> 
>>             popup.addEventHandler(WindowEvent.WINDOW_HIDDEN, e -> {
>>                 // Quick-fix for MacOs:
>>                 // If an item is selected in the overflow list and we select an item from the visible list,
>>                 // selection in the overflow list remains on opening the overflow list for the first time but overflow icon becomes grey.
>>                 // If we open overflow list again, selection will get removed.
>>                 Platform.runLater(() -> {
>>                     // Put the overflowed items back to the list,
>>                     // otherwise subsequent prefWidth(..)/prefHeight(..) may return wrong values.
>>                     overflowItems.clear();
>>                     for (Node item : getSkinnable().getItems()) {
>>                         if (!box.getChildren().contains(item)) {
>>                             overflowItems.add(item);
>>                         }
>>                     }
>>                 });
>>             });
>> 
>> 
>> What is your suggestion? Should it be **quick**-fixed in this PR or should a new issue be created for it?
>
>> Should it be **quick**-fixed in this PR
> 
> I would rather not.
> 
> We *could* create a ticket named "improve focus handling in ToolBar" but then again, since no functionality is disabled, it will be a P5 (very low priority).

What @andy-goryachev-oracle  mentioned above seems ok to me. If focus indicator function is not broken, we can go ahead with this PR and create separate ticket to fix other issues.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1434#issuecomment-2067559676