RFR: 8328577: Toolbar's overflow button overlaps the items [v6]

[eduardsdv]

On Mon, 15 Apr 2024 15:41:19 GMT, eduardsdv <duke at openjdk.org> wrote:

>> This change fixes the calculation of which nodes go to the toolbar and which go to the overflow menu.
>> It is now determined before the nodes are removed from the scene graph.
>> This is important because the values returned by ``Node.prefWidth(..)``/``Node.prefHeight(..)`` may depend on whether the node is added to the scene graph.
>> 
>> Furthermore I corrected the ``hasOveflow`` value passed to the ``organizeOverflow(double, boolean)`` in ``correctOverflow(double)``.
>
> eduardsdv has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8328577: Refactor and fix binding of style related properties

I tested the focus handling with the MonkeyTest app. I also tested it with a ListView in the toolbar (see PR: https://github.com/andy-goryachev-oracle/MonkeyTest/pull/2).
All components are reachable with the mouse and the keyboard.
I found only one issue with closing the overflow-menu with the ESC key when the currently focused Node (e.g. ListView) processes the ESC itself. This issue is also reproducible in the version before PR.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1434#issuecomment-2068811858