RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v15]

Andy Goryachev angorya at openjdk.org
Tue Apr 23 19:03:39 UTC 2024


On Tue, 23 Apr 2024 17:42:03 GMT, Oliver Kopp <duke at openjdk.org> wrote:

>> Oliver Kopp has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add missing exports
>
> tests/system/src/test/java/test/com/sun/glass/ui/win/WinTextRangeProviderTest.java line 48:
> 
>> 46: import static org.junit.jupiter.api.Assertions.assertEquals;
>> 47: 
>> 48: @EnabledOnOs({OS.WINDOWS})
> 
> I did not use `Platform`s OS detection, because this seems to be more resource friendly and native JUnit5. I can switch to the style of `test.com.sun.glass.ui.gtk.Gtk2RemovalCommon`, i.e., use `if (!PlatformUtil.isWindows()) return;` in all test methdos.

Interesting = @kevinrushforth what do you think?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1442#discussion_r1576763192


More information about the openjfx-dev mailing list