RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v16]

[Andy Goryachev]

On Tue, 23 Apr 2024 17:47:03 GMT, Oliver Kopp <duke at openjdk.org> wrote:

>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>> 
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, then an addition of `start` to it leads to a negative value. This is "fixed" by using `Math.max` comparing the `maxLength` and `maxLength + start`.
>
> Oliver Kopp has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fix JavaDoc formatting
>  - Discard changes to modules/javafx.graphics/src/test/addExports

Turns out I cannot reproduce the issue on my windows 11 setup.
Installed deepl app, ctrl-c-c pops up the translation window, translation works, close the window, start the test app - can type into a TextField just fine.

the code looks ok to me, one change must be made to a .classpath file - take a look at
https://github.com/andy-goryachev-oracle/jfx/pull/new/review.1442
branch (I think you can just merge it into yours)

-------------

PR Review: https://git.openjdk.org/jfx/pull/1442#pullrequestreview-2018266546