RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v18]

[Oliver Kopp]

On Wed, 24 Apr 2024 07:45:50 GMT, Oliver Kopp <duke at openjdk.org> wrote:

>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>> 
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, then an addition of `start` to it leads to a negative value. This is "fixed" by using `Math.max` comparing the `maxLength` and `maxLength + start`.
>
> Oliver Kopp has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unused import

Note that the tests need to be run using `FULL_TEST = true`. IMHO setting it in `gradle.properties` is enough. I tried the command line `./gradlew --info -PFULL_TEST=true -PTEST_ONLY=true test`, which worked, too.

I needed to start the tests manually, because the CI did not cover that case:

    ./gradlew --info -PFULL_TEST=true -PTEST_ONLY=true systemTests:test --tests "test.com.sun.glass.ui.win.WinTextRangeProviderTest"

The tests needed a fix. Done in 974bf468c82.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1442#issuecomment-2074385269