RFR: 8320563: Remove D3D9 code paths in favor of D3D9Ex
Nir Lisker
nlisker at openjdk.org
Thu Apr 25 11:16:33 UTC 2024
On Tue, 23 Apr 2024 10:33:58 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:
> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are no longer needed.
>
> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I changed the type to explicitly use `IDirect3DDevice9Ex`. Technically it doesn't matter much (`IDirect3DDevice9Ex` inherits `IDirect3DDevice` - it was leveraged to transparently use the Ex device in the backend) but now we don't have the non-Ex device, so that keeps it a bit more consistent and clear IMO.
>
> Verified by running tests on Windows 11, did not notice any regressions. Unfortunately I have no way to test this on older systems.
I traced the issue to commit id 3914db26f3abb573ed0e320a361477e1d3e7a9ac, which is a merge Kevin did ~6 weeks ago. Placing the head on this commit or after causes the above error, but moving 1 commit back to "Create release notes for JavaFX 22" lets the application start normally.
I understand that this PR has nothing to do with this, I just can't test it considering this problem.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1445#issuecomment-2076940263
More information about the openjfx-dev
mailing list